syzbot

======================================================
WARNING: possible circular locking dependency detected
6.1.132-syzkaller #0 Not tainted
------------------------------------------------------
syz.6.2008/10542 is trying to acquire lock:
ffff888061a2e650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
ffff888061a2e650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
ffff888061a2e650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x2073/0x4e40 fs/ocfs2/aops.c:1670

but task is already holding lock:
ffff888071f0dbe0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x1cd/0x390 fs/ocfs2/aops.c:1902

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3
 (&oi->ip_alloc_sem){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_read_virt_blocks+0x2dc/0xab0 fs/ocfs2/extent_map.c:976
       ocfs2_read_dir_block+0x102/0x5b0 fs/ocfs2/dir.c:508
       ocfs2_dir_foreach_blk_el fs/ocfs2/dir.c:1842 [inline]
       ocfs2_dir_foreach_blk+0x2a1/0x1e10 fs/ocfs2/dir.c:1928
       ocfs2_dir_foreach+0x20c/0x270 fs/ocfs2/dir.c:1938
       ocfs2_empty_dir+0x446/0x7b0 fs/ocfs2/dir.c:2156
       ocfs2_rename+0x26c2/0x4000 fs/ocfs2/namei.c:1499
       vfs_rename+0xd32/0x10f0 fs/namei.c:4874
       do_renameat2+0xde0/0x1440 fs/namei.c:5027
       __do_sys_rename fs/namei.c:5073 [inline]
       __se_sys_rename fs/namei.c:5071 [inline]
       __x64_sys_rename+0x82/0x90 fs/namei.c:5071
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (jbd2_handle){++++}-{0:0}
:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:361
       vfs_mknod+0x444/0x4d0 fs/namei.c:3985
       do_mknodat+0x3f8/0x5a0 fs/namei.c:-1
       __do_sys_mknodat fs/namei.c:4063 [inline]
       __se_sys_mknodat fs/namei.c:4060 [inline]
       __x64_sys_mknodat+0xa5/0xc0 fs/namei.c:4060
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:361
       vfs_mknod+0x444/0x4d0 fs/namei.c:3985
       do_mknodat+0x3f8/0x5a0 fs/namei.c:-1
       __do_sys_mknodat fs/namei.c:4063 [inline]
       __se_sys_mknodat fs/namei.c:4060 [inline]
       __x64_sys_mknodat+0xa5/0xc0 fs/namei.c:4060
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#5){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
       ocfs2_write_begin_nolock+0x2073/0x4e40 fs/ocfs2/aops.c:1670
       ocfs2_write_begin+0x201/0x390 fs/ocfs2/aops.c:1904
       generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3845
       __generic_file_write_iter+0x176/0x400 mm/filemap.c:3973
       ocfs2_file_write_iter+0x19d7/0x2280 fs/ocfs2/file.c:2469
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x857/0xbc0 fs/read_write.c:584
       ksys_write+0x19c/0x2c0 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#5 --> jbd2_handle --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_alloc_sem);
  lock(sb_internal#5);

 *** DEADLOCK ***

4 locks held by syz.6.2008/10542:
 #0: ffff88807d2d25e8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2ba/0x360 fs/file.c:1032
 #1: ffff888061a2e460 (sb_writers#26){.+.+}-{0:0}, at: vfs_write+0x269/0xbc0 fs/read_write.c:580
 #2: ffff888071f0df48 (&sb->s_type->i_mutex_key#41){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff888071f0df48 (&sb->s_type->i_mutex_key#41){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x454/0x2280 fs/ocfs2/file.c:2399
 #3: ffff888071f0dbe0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x1cd/0x390 fs/ocfs2/aops.c:1902

stack backtrace:
CPU: 1 PID: 10542 Comm: syz.6.2008 Not tainted 6.1.132-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1891 [inline]
 sb_start_intwrite include/linux/fs.h:2013 [inline]
 ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
 ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
 ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
 ocfs2_write_begin_nolock+0x2073/0x4e40 fs/ocfs2/aops.c:1670
 ocfs2_write_begin+0x201/0x390 fs/ocfs2/aops.c:1904
 generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3845
 __generic_file_write_iter+0x176/0x400 mm/filemap.c:3973
 ocfs2_file_write_iter+0x19d7/0x2280 fs/ocfs2/file.c:2469
 call_write_iter include/linux/fs.h:2265 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x857/0xbc0 fs/read_write.c:584
 ksys_write+0x19c/0x2c0 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f2220f8d169
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2221d05038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f22211a5fa0 RCX: 00007f2220f8d169
RDX: 0000000000000028 RSI: 00002000000000c0 RDI: 0000000000000004
RBP: 00007f222100e2a0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f22211a5fa0 R15: 00007ffebc446fd8
 </TASK>
ocfs2: Unmounting device (7,6) on (node local)