======================================================
WARNING: possible circular locking dependency detected
6.14.0-rc7-syzkaller-ga2392f333575 #0 Not tainted
------------------------------------------------------
syz.5.488/8335 is trying to acquire lock:
ffff0000f1138660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314

but task is already holding lock:
ffff0000f11389c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline]
ffff0000f11389c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}:
       down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:877 [inline]
       ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x268/0xa90 fs/ocfs2/quota_global.c:828
       dqget+0x660/0xcec fs/quota/dquot.c:977
       __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1505
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1567
       ocfs2_get_init_inode+0x14c/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x878/0x2438 fs/ocfs2/namei.c:310
       ocfs2_create+0x194/0x4d4 fs/ocfs2/namei.c:673
       lookup_open fs/namei.c:3651 [inline]
       open_last_lookups fs/namei.c:3750 [inline]
       path_openat+0x13ec/0x2b1c fs/namei.c:3986
       do_filp_open+0x1e8/0x404 fs/namei.c:4016
       do_sys_openat2+0x124/0x1b8 fs/open.c:1428
       do_sys_open fs/open.c:1443 [inline]
       __do_sys_openat fs/open.c:1459 [inline]
       __se_sys_openat fs/open.c:1454 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1454
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #5 (&dquot->dq_lock){+.+.}-{4:4}:
       __mutex_lock_common+0x1f0/0x24b8 kernel/locking/mutex.c:585
       __mutex_lock kernel/locking/mutex.c:730 [inline]
       mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:782
       wait_on_dquot fs/quota/dquot.c:354 [inline]
       dqget+0x5f0/0xcec fs/quota/dquot.c:972
       dquot_transfer+0x3a8/0x5c0 fs/quota/dquot.c:2154
       ext4_setattr+0x8b8/0x173c fs/ext4/inode.c:5401
       notify_change+0x9f0/0xca0 fs/attr.c:552
       chown_common+0x440/0x708 fs/open.c:782
       vfs_fchown fs/open.c:850 [inline]
       ksys_fchown+0xe0/0x158 fs/open.c:862
       __do_sys_fchown fs/open.c:867 [inline]
       __se_sys_fchown fs/open.c:865 [inline]
       __arm64_sys_fchown+0x7c/0x94 fs/open.c:865
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #4 (&ei->xattr_sem){++++}-{4:4}:
       down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
       ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline]
       ext4_xattr_set_handle+0x1dc/0x12d0 fs/ext4/xattr.c:2373
       ext4_initxattrs+0xa4/0x11c fs/ext4/xattr_security.c:44
       security_inode_init_security+0x73c/0x908 security/security.c:1852
       ext4_init_security+0x44/0x58 fs/ext4/xattr_security.c:58
       __ext4_new_inode+0x2d44/0x39e4 fs/ext4/ialloc.c:1324
       ext4_create+0x234/0x480 fs/ext4/namei.c:2841
       lookup_open fs/namei.c:3651 [inline]
       open_last_lookups fs/namei.c:3750 [inline]
       path_openat+0x13ec/0x2b1c fs/namei.c:3986
       do_filp_open+0x1e8/0x404 fs/namei.c:4016
       do_sys_openat2+0x124/0x1b8 fs/open.c:1428
       do_sys_open fs/open.c:1443 [inline]
       __do_sys_openat fs/open.c:1459 [inline]
       __se_sys_openat fs/open.c:1454 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1454
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #3 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0xf34/0x11c4 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x3d0/0x71c fs/ocfs2/journal.c:352
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x840/0x4254 fs/ocfs2/suballoc.c:832
       ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982
       ocfs2_mknod+0xdc8/0x2438 fs/ocfs2/namei.c:347
       ocfs2_create+0x194/0x4d4 fs/ocfs2/namei.c:673
       lookup_open fs/namei.c:3651 [inline]
       open_last_lookups fs/namei.c:3750 [inline]
       path_openat+0x13ec/0x2b1c fs/namei.c:3986
       do_filp_open+0x1e8/0x404 fs/namei.c:4016
       do_sys_openat2+0x124/0x1b8 fs/open.c:1428
       do_sys_open fs/open.c:1443 [inline]
       __do_sys_openat fs/open.c:1459 [inline]
       __se_sys_openat fs/open.c:1454 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1454
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x58/0x2fc kernel/locking/rwsem.c:1524
       ocfs2_start_trans+0x3c4/0x71c fs/ocfs2/journal.c:350
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x840/0x4254 fs/ocfs2/suballoc.c:832
       ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982
       ocfs2_mknod+0xdc8/0x2438 fs/ocfs2/namei.c:347
       ocfs2_create+0x194/0x4d4 fs/ocfs2/namei.c:673
       lookup_open fs/namei.c:3651 [inline]
       open_last_lookups fs/namei.c:3750 [inline]
       path_openat+0x13ec/0x2b1c fs/namei.c:3986
       do_filp_open+0x1e8/0x404 fs/namei.c:4016
       do_sys_openat2+0x124/0x1b8 fs/open.c:1428
       do_sys_open fs/open.c:1443 [inline]
       __do_sys_openat fs/open.c:1459 [inline]
       __se_sys_openat fs/open.c:1454 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1454
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #1 (sb_internal#3){.+.+}-{0:0}:
       __lock_release kernel/locking/lockdep.c:5565 [inline]
       lock_release+0x358/0x9e4 kernel/locking/lockdep.c:5872
       up_write+0x88/0x760 kernel/locking/rwsem.c:1629
       inode_unlock include/linux/fs.h:882 [inline]
       ocfs2_free_ac_resource fs/ocfs2/suballoc.c:130 [inline]
       ocfs2_free_alloc_context+0x94/0x188 fs/ocfs2/suballoc.c:144
       ocfs2_write_begin_nolock+0x3de4/0x3e90 fs/ocfs2/aops.c:1810
       ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1889
       generic_perform_write+0x29c/0x868 mm/filemap.c:4102
       __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4203
       ocfs2_file_write_iter+0x161c/0x1f3c fs/ocfs2/file.c:2469
       new_sync_write fs/read_write.c:586 [inline]
       vfs_write+0x704/0xa9c fs/read_write.c:679
       ksys_write+0x15c/0x26c fs/read_write.c:731
       __do_sys_write fs/read_write.c:742 [inline]
       __se_sys_write fs/read_write.c:739 [inline]
       __arm64_sys_write+0x7c/0x90 fs/read_write.c:739
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3163 [inline]
       check_prevs_add kernel/locking/lockdep.c:3282 [inline]
       validate_chain kernel/locking/lockdep.c:3906 [inline]
       __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5228
       lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5851
       down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
       ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x268/0xa90 fs/ocfs2/quota_global.c:828
       dqget+0x660/0xcec fs/quota/dquot.c:977
       __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1505
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1567
       ocfs2_get_init_inode+0x14c/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x878/0x2438 fs/ocfs2/namei.c:310
       ocfs2_create+0x194/0x4d4 fs/ocfs2/namei.c:673
       lookup_open fs/namei.c:3651 [inline]
       open_last_lookups fs/namei.c:3750 [inline]
       path_openat+0x13ec/0x2b1c fs/namei.c:3986
       do_filp_open+0x1e8/0x404 fs/namei.c:4016
       do_sys_openat2+0x124/0x1b8 fs/open.c:1428
       do_sys_open fs/open.c:1443 [inline]
       __do_sys_openat fs/open.c:1459 [inline]
       __se_sys_openat fs/open.c:1454 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1454
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

other info that might help us debug this:

Chain exists of:
  &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
  lock(&ocfs2_quota_ip_alloc_sem_key);

 *** DEADLOCK ***

5 locks held by syz.5.488/8335:
 #0: ffff0000f6aee420 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:547
 #1: ffff0000f11ea640 (&type->i_mutex_dir_key#10){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline]
 #1: ffff0000f11ea640 (&type->i_mutex_dir_key#10){+.+.}-{4:4}, at: open_last_lookups fs/namei.c:3747 [inline]
 #1: ffff0000f11ea640 (&type->i_mutex_dir_key#10){+.+.}-{4:4}, at: path_openat+0x684/0x2b1c fs/namei.c:3986
 #2: ffff0000f113d100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline]
 #2: ffff0000f113d100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x164/0x4254 fs/ocfs2/suballoc.c:786
 #3: ffff0000ddb720a8 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x25c/0xa90 fs/ocfs2/quota_global.c:823
 #4: ffff0000f11389c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline]
 #4: ffff0000f11389c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313

stack backtrace:
CPU: 1 UID: 0 PID: 8335 Comm: syz.5.488 Not tainted 6.14.0-rc7-syzkaller-ga2392f333575 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call trace:
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C)
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120
 dump_stack+0x1c/0x28 lib/dump_stack.c:129
 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2076
 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2208
 check_prev_add kernel/locking/lockdep.c:3163 [inline]
 check_prevs_add kernel/locking/lockdep.c:3282 [inline]
 validate_chain kernel/locking/lockdep.c:3906 [inline]
 __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5228
 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5851
 down_write+0x50/0xc0 kernel/locking/rwsem.c:1577
 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
 ocfs2_acquire_dquot+0x268/0xa90 fs/ocfs2/quota_global.c:828
 dqget+0x660/0xcec fs/quota/dquot.c:977
 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1505
 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1567
 ocfs2_get_init_inode+0x14c/0x1c0 fs/ocfs2/namei.c:202
 ocfs2_mknod+0x878/0x2438 fs/ocfs2/namei.c:310
 ocfs2_create+0x194/0x4d4 fs/ocfs2/namei.c:673
 lookup_open fs/namei.c:3651 [inline]
 open_last_lookups fs/namei.c:3750 [inline]
 path_openat+0x13ec/0x2b1c fs/namei.c:3986
 do_filp_open+0x1e8/0x404 fs/namei.c:4016
 do_sys_openat2+0x124/0x1b8 fs/open.c:1428
 do_sys_open fs/open.c:1443 [inline]
 __do_sys_openat fs/open.c:1459 [inline]
 __se_sys_openat fs/open.c:1454 [inline]
 __arm64_sys_openat+0x1f0/0x240 fs/open.c:1454
 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600